Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor Reallocate since it introduced in upstream v8 #33402

Closed
wants to merge 1 commit into from
Closed

src: refactor Reallocate since it introduced in upstream v8 #33402

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Fix #33401.

cherrpick from V8 canary branch

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 14, 2020
@gengjiawen
Copy link
Member Author

Fast track ?

@gengjiawen gengjiawen mentioned this pull request May 14, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31322/

@gengjiawen gengjiawen added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31323/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31324/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31326/

gengjiawen added a commit that referenced this pull request May 14, 2020
@gengjiawen
src: refactor Reallocate since it introduced in upstream v8
4ad2692 
PR-URL: #33402
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gengjiawen
Copy link
Member Author

Landed in 4ad2692

@gengjiawen gengjiawen closed this May 14, 2020
@gengjiawen gengjiawen deleted the build/fix branch May 14, 2020 14:38
codebytere pushed a commit that referenced this pull request May 16, 2020
@gengjiawen @codebytere
src: refactor Reallocate since it introduced in upstream v8
fd89ef1 
PR-URL: #33402
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MacOS build fails
8 participants
@gengjiawen @nodejs-github-bot @jasnell @benjamingr @cjihrig @richardlau @himself65 @codebytere